Skip to content

Conversation

MatteoGiomi
Copy link
Member

Fix for #43.

Copy link
Collaborator

@oalifdal oalifdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @MatteoGiomi !

Copy link

@lifepillar lifepillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'd be more drastic and replace every invalid character (I've left a suggestion).

@MatteoGiomi
Copy link
Member Author

Thanks for having a look @oalifdal, @lifepillar. I am waiting for #41 to be merged before going ahead with this one. I'll then rebase and merge it.

@MatteoGiomi MatteoGiomi force-pushed the matteo/fix/so-math-in-column-names branch from 86f970c to 90f77df Compare September 25, 2025 09:33
@MatteoGiomi MatteoGiomi force-pushed the matteo/fix/so-math-in-column-names branch from 90f77df to d371ff9 Compare September 25, 2025 09:38
@MatteoGiomi
Copy link
Member Author

Thanks a lot @oalifdal and @lifepillar for the review, I waited for #41 to be merged and then rebased.

@MatteoGiomi MatteoGiomi merged commit 741ca08 into main Sep 25, 2025
4 checks passed
@MatteoGiomi MatteoGiomi deleted the matteo/fix/so-math-in-column-names branch September 25, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants