ci: validate secrets refactor #18772
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (137)
|
siddarthkay
force-pushed
the
secrets-refactor
branch
from
2a71da2 to
e0b5773
Compare
siddarthkay
force-pushed
the
secrets-refactor
branch
15 times, most recently
from
4543c69 to
a4ce223
Compare
siddarthkay
requested review from
iurimatias
and removed request for
a team
Introduces --verify-credentials flag which can be passed to status app and it will check for all the necessary credentials provided by status-jenkins-lib. related changes are here : status-im/status-jenkins-lib#120 Adds an Audit stage in jenkins which checks for these credentials, this is an integration test in CI to ensure that bundled app has all the necessary secrets. Shorten existing stage names in Jenkins for better readability.
siddarthkay
force-pushed
the
secrets-refactor
branch
from
a4ce223 to
7c9e24c
Compare
jakubgs
reviewed
Sep 11, 2025
Comment on lines
+6
to
+9
| let thingsToCheck = getEnv("THINGS_TO_CHECK") | ||
| if thingsToCheck.len == 0: | ||
| echo "ERROR: THINGS_TO_CHECK environment variable not set" | ||
| return 1 |
There was a problem hiding this comment.
This seem way to complicated to me. Why can't we write a wrapper around getEnv() in src/env_cli_vars.nim:
status-desktop/src/env_cli_vars.nim
Lines 46 to 48 in ac2ac73
And just check if it's an empty string and fail on that with an assert or something.
I thought we could use existsEnv() but empty string is an invalid value so just checking that is better.
There was a problem hiding this comment.
According to docs static blocks are executed at built time:
https://nim-lang.org/docs/manual.html#statements-and-expressions-static-statementslashexpression
But I don't see any usage of static in src/env_cli_vars.nim or src/constants.nim.
There was a problem hiding this comment.
The key point is that we want a way that live closest to where the vars are sourced, that way we have a better chance of developers also maintaining that. We could define a mustGetEnv() that is used only for secrets, or even more explicit ciMustGetEnv() that only fails on missing value when CI=true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces
--verify-credentialsflag which can be passed to status app and it will check for all the necessary credentials provided bystatus-jenkins-lib.related changes are here : https://github.com/status-im/status-jenkins-lib/pull/120
Adds an
Auditstage in jenkins which checks for these credentials, this is an integration test in CI to ensure that bundled app has all the necessary secrets.