chore(Makefile): create targets to update and build translations #18821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (34)
|
caybro
requested review from
jrainville,
micieslak and
alexjba
and removed request for
iurimatias
caybro
force-pushed
the
18820-i18n-update-makefile
branch
2 times, most recently
from
3c4c70b to
3842f30
Compare
caybro
force-pushed
the
18820-i18n-update-makefile
branch
2 times, most recently
from
9afa7ef to
e69179f
Compare
- create dedicated Makefile targets: `update-translations` and `compile-translations` that extract/update/merge and compile the TS files respectively - these targets can then later be invoked externally by CI automation - provide a small manual Python script that transforms the empty `qml_base_en.ts` into a pre-filled `qml_base_lokalise_en.ts` for the purpose of AI enabled translations on Lokalise - add a sample Czech translation to test the changes (to be finished later separately) - update the i18n README Fixes #18820
caybro
force-pushed
the
18820-i18n-update-makefile
branch
from
e69179f to
fc89e9f
Compare
caybro
commented
Sep 15, 2025
| "ar": Description(name: "Arabic", native: "العربية", flag: "", state: State.Alpha), | ||
| "bn": Description(name: "Bengali", native: "বাংলা", flag: "X", state: State.Alpha), | ||
| "bn": Description(name: "Bengali", native: "বাংলা", flag: "X", state: State.Alpha), | ||
| "cs": Description(name: "Czech", native: "čeština", flag: "🇨🇿", state: State.Alpha), |
There was a problem hiding this comment.
Ideally this should be done on the fly, and not hardcoded here. Will be tackled in a separate issue #18330
caybro
commented
Sep 15, 2025
| update-translations: | log-update-translations | ||
| cmake -S $(TS_SOURCE_DIR) -B $(TS_BUILD_DIR) -Wno-dev $(HANDLE_OUTPUT) | ||
| cmake --build $(TS_BUILD_DIR) --target update_application_translations $(HANDLE_OUTPUT) | ||
| # + cd scripts/translationScripts && ./fixup-base-ts-for-lokalise.py $(HANDLE_OUTPUT) |
There was a problem hiding this comment.
This is a manual step (for now) as it requires Python; no change here. We probably don't want or need this to be run everywhere (mac, Windows), can be done only on CI
sunleos
approved these changes
Sep 15, 2025
|
@osmaczko @jrainville kind reminder for a review; don't get scared by this of the PR, the code changes are fairly minimal; tested by Volo on Lokalise, and me in the app |
osmaczko
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
update-translationsandcompile-translationsthat extract/update/merge and compile the TS files respectivelyqml_base_en.tsinto a pre-filledqml_base_lokalise_en.tsfor the purpose of AI enabled translations on LokaliseFixes #18820
Affected areas
Makefile
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Impact on end user
UI is translated :)
How to test
Risk