You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed tooltip from checksum indicator on all platforms.
- Checksum mismatch is now treated as a standard error instead of a tooltip hint.
- Prevents adding an address with an invalid checksum.
Closes#19081
previously the checksum was only a warning and now it's an error state. Are we sure this is the proper behavior? I suspect there's some places in the app where we can copy wallet the address and it will fail with this error. When reporting this bug I've used existing account addresses copy-pasted from within the app and the address was lower case.
previously the checksum was only a warning and now it's an error state. Are we sure this is the proper behavior? I suspect there's some places in the app where we can copy wallet the address and it will fail with this error. When reporting this bug I've used existing account addresses copy-pasted from within the app and the address was lower case.
@alexjba this might be my mistake, I though we only allow checksums addresses, but I guess I am wrong. I was trying to find the Saved Address designs from before to verify but was unable to find them.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noeliaSD
requested review from
Khushboo-dev-cpp,
alaibe,
alexjba and
friofry
and removed request for
a team and
micieslak
Closes #19081
What does the PR do
As discused with designer and team here:
Affected areas
Wallet / Saved addresses popup
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Screen.Recording.2025-11-11.at.17.55.42.mov
Impact on end user
Save address checksum validation improved
How to test
Use the same steps than shown in the video shared.
Risk
Low