feat: integrate sds when sending community messages. #6884
+953
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (533)
|
4 tasks
kaichaosun
force-pushed
the
feat/sds-integration-v2
branch
2 times, most recently
from
8b87980 to
feb0968
Compare
kaichaosun
force-pushed
the
feat/sds-integration-v2
branch
from
feb0968 to
5881c80
Compare
Ivansete-status
force-pushed
the
feat/sds-integration-v2
branch
5 times, most recently
from
faf527d to
7598226
Compare
4 tasks
Ivansete-status
force-pushed
the
feat/sds-integration-v2
branch
8 times, most recently
from
ce96046 to
6596593
Compare
|
Here's some notes from our call:
I would recommend debugging why Nix wrapped GCC is not being used by CGO, because it should include the lib and header paths via |
This reverts commit acccc67.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6884 +/- ##
============================================
- Coverage 59.54% 38.55% -20.99%
============================================
Files 806 806
Lines 114868 114936 +68
============================================
- Hits 68401 44318 -24083
- Misses 39462 66356 +26894
+ Partials 7005 4262 -2743
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDS is a protocol to improve reliability of community messages. SDS spec
A description to understand introduced changes without reading the code.
Important changes:
Relates #waku-org/pm#194