ci: go tool go-generate-fast #6933
Conversation
Jenkins Builds
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6933 +/- ##
===========================================
+ Coverage 58.88% 58.95% +0.06%
===========================================
Files 822 822
Lines 121999 121999
===========================================
+ Hits 71838 71922 +84
+ Misses 42727 42659 -68
+ Partials 7434 7418 -16
Flags with carried forward coverage won't be shown. Click here to find out more. |
igor-sirotin
force-pushed
the
ci/go-tool-go-generate-fast
branch
from
5826843 to
fa86b5e
Compare
igor-sirotin
requested review from
dlipicar,
jakubgs,
osmaczko and
siddarthkay
|
The hell is happening in this PR? 
This is un-reviewable. |
There was a problem hiding this comment.
That is a lot of stuff just for our tooling:
~/work/status-go ci/go-tool-go-generate-fast
> g show --stat | awk -F'[ /]' '/^ vendor/{print $2 "/" $3 "/" $4}' | sort -u | grep -v modules.txt | xargs du -hsc | tail -n1
18M total
I really hate the use of vendor folder, but if that's what the devs like...
|
@jakubgs I have the vendor changes in a separate commit, you can review the actual changes in d31bbe7
I agree it's a lot. But this tool will save devs 25sec on every build, which I believe is very important.
I also hate it. But that is the only way to secure dependencies in Go, because they don't have a proper package manager. We can re-consider this, if we believe that we're safe enough from this to happen. I'm truly open to this discussion, it's gonna be easy to convince me 😄 |
|
I'd love to approve it but my browser freezes when i try to load the diff... |
|
Gonna merge after this one, not to pollute the repo: |
4 participants
Description
Sine we don't stage the generated files, it is essential to use cache, because normal generation takes ~25s.
I have implemented support for
go tooltogo-generate-fast. Using our fork for now, but I have a PR for the upstream: