-
Notifications
You must be signed in to change notification settings - Fork 262
fix: improve peer exchange loop logic #7005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Jenkins Builds
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7005 +/- ##
===========================================
+ Coverage 55.11% 59.48% +4.37%
===========================================
Files 820 821 +1
Lines 116628 116647 +19
===========================================
+ Hits 64275 69389 +5114
+ Misses 45548 40169 -5379
- Partials 6805 7089 +284
Flags with carried forward coverage won't be shown. Click here to find out more.
|
w.logger.Debug("Running peer exchange loop") | ||
err := w.node.PeerExchange().Request( | ||
|
||
case status, ok := <-w.topicHealthStatusChan: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iirc topic Health status for light/edge nodes where peer-Exchange is generally used is not implemented in go-waku. It is only implemented for relay mode.
Did you validate this in a setup and noticed that health is reported based on connections to Filter peers and available lightpush peers in peerStore?
that is how it is supposed to be derived as per #4628
- In lightMode: status-go shall derive it based on peer connections to Filter and lightpush(This shall be later migrated to SDK layer once https://github.com/status-im/status-go/pull/4665 is complete)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, weird. I did test it indeed and it looked like it's working 🤔
Let me double check carefully what's happening.
Thank you ❤️
Closes #6949
Closes #4628
Requires:
Description
Instead of running peer exchange each 5 seconds, run it on demand for specific shard