refactor: let messaging modules own sqlite reference impl

[osmaczko]

iterates: #6792

[status-im-auto]

Jenkins Builds

Click to see older builds (7)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	a570c8b	#1	2025-10-17 19:13:17	~59 sec	macos/status-go	📄log
✖️	a570c8b	#1	2025-10-17 19:13:21	~1 min	tests-rpc	📄log
❌	a570c8b	#1	2025-10-17 19:13:21	~1 min	linux/nwaku	📄log
❌	a570c8b	#1	2025-10-17 19:13:21	~1 min	linux/status-go	📄log
✖️	a570c8b	#1	2025-10-17 19:13:25	~1 min	tests	📄log
✔️	a570c8b	#1	2025-10-17 19:21:16	~8 min	windows/status-go	📦zip
✖️	a570c8b	#2	2025-10-19 12:04:21	~59 sec	tests	📄log

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	4079dc2	#2	2025-10-19 12:20:10	~3 min	macos/status-go	📦zip
✔️	4079dc2	#2	2025-10-19 12:21:00	~4 min	linux/status-go	📦zip
✔️	4079dc2	#2	2025-10-19 12:25:20	~8 min	windows/status-go	📦zip
✖️	4079dc2	#3	2025-10-19 12:26:52	~10 min	tests	📄log
✔️	4079dc2	#2	2025-10-19 12:27:40	~11 min	linux/nwaku	📦zip
✖️	4079dc2	#2	2025-10-19 12:34:31	~17 min	tests-rpc	📄log
✔️	fbab1f0	#3	2025-10-19 18:17:22	~3 min	macos/status-go	📦zip
✔️	fbab1f0	#3	2025-10-19 18:17:53	~4 min	linux/status-go	📦zip
✔️	fbab1f0	#3	2025-10-19 18:21:43	~7 min	windows/status-go	📦zip
✔️	fbab1f0	#3	2025-10-19 18:24:49	~11 min	linux/nwaku	📦zip
✔️	fbab1f0	#3	2025-10-19 18:25:28	~11 min	tests-rpc	📄log
✔️	fbab1f0	#4	2025-10-19 18:41:08	~27 min	tests	📄log

[codecov]

Codecov Report

❌ Patch coverage is 66.59960% with 166 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.49%. Comparing base (78d6e84) to head (fbab1f0).

Files with missing lines	Patch %	Lines
messaging/adapters/persistence.go	39.65%	30 Missing and 5 partials ⚠️
...essaging/layers/segmentation/sqlite_persistence.go	64.55%	21 Missing and 7 partials ⚠️
messaging/layers/transport/sqlite_persistence.go	75.23%	19 Missing and 7 partials ⚠️
messaging/sqlite_persistence.go	58.13%	12 Missing and 6 partials ⚠️
...ssaging/internal/sqlite_segmenation_persistence.go	0.00%	12 Missing ⚠️
messaging/internal/sqlite_transport_persistence.go	0.00%	12 Missing ⚠️
messaging/common/persistence_in_memory.go	81.81%	8 Missing and 2 partials ⚠️
messaging/waku/sqlite_persistence.go	81.25%	6 Missing and 3 partials ⚠️
messaging/internal/sqlite_waku_encryption.go	0.00%	8 Missing ⚠️
messaging/api.go	50.00%	2 Missing and 1 partial ⚠️
... and 2 more

Additional details and impacted files

@@                              Coverage Diff                              @@
##           refactor/messaging-persistence-interfaces    #7011      +/-   ##
=============================================================================
- Coverage                                      59.49%   59.49%   -0.01%     
=============================================================================
  Files                                            826      836      +10     
  Lines                                         116617   116829     +212     
=============================================================================
+ Hits                                           69377    69502     +125     
- Misses                                         40153    40219      +66     
- Partials                                        7087     7108      +21     

Flag	Coverage Δ
functional	35.27% <41.64%> (-0.02%)	⬇️
unit	55.03% <63.98%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
messaging/common/message_sender.go	65.77% <100.00%> (+0.34%)	⬆️
messaging/core.go	56.15% <100.00%> (+0.11%)	⬆️
...essaging/layers/segmentation/migrations/migrate.go	100.00% <100.00%> (ø)
messaging/layers/transport/filters_manager.go	76.31% <ø> (ø)
messaging/layers/transport/migrations/migrate.go	100.00% <100.00%> (ø)
messaging/waku/gowaku.go	65.90% <100.00%> (ø)
messaging/waku/migrations/migrate.go	100.00% <100.00%> (ø)
protocol/messaging_persistence.go	78.21% <100.00%> (+3.37%)	⬆️
messaging/common/message_segmentation.go	66.00% <66.66%> (-1.48%)	⬇️
messaging/api.go	77.52% <50.00%> (+0.34%)	⬆️
... and 10 more

... and 36 files with indirect coverage changes

[osmaczko]

Closing in favor of updated #7011