Skip to content

let's see how windows CI handles our PNP tests #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

let's see how windows CI handles our PNP tests #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 38 additions & 49 deletions tests/index-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,66 +85,55 @@ describe('resolve-package-path', function () {
});
});

if (require('os').platform() !== 'win32') {
describe('yarn pnp usage', function () {
this.timeout(30000); // in-case the network IO is slow
let app: Project;
const execa = require('execa');

beforeEach(function () {
app = new Project('dummy', '1.0.0', app => {
app.pkg.private = true;
app.pkg.name;
app.pkg.scripts = {
test: 'node ./test.js',
};
app.pkg.installConfig = {
pnp: true,
};
app.addDependency('ember-source-channel-url', '1.1.0');
app.addDependency('resolve-package-path', 'link:' + path.join(__dirname, '..'));
app.files = {
'test.js': `
if (require('resolve-package-path')(process.argv[2], __dirname)) {
console.log('found');
process.exitCode = 0;
} else {
console.log('not-found');
process.exitCode = 1;
}`,
};
});
describe('yarn pnp usage', function () {
this.timeout(30000); // in-case the network IO is slow
let app: Project;
const execa = require('execa');

app.writeSync();
execa.sync('yarn', {
cwd: app.baseDir,
});
beforeEach(function () {
app = new Project('dummy', '1.0.0', app => {
app.pkg.private = true;
app.pkg.name;
app.pkg.scripts = {
test: 'node ./test.js',
};
app.pkg.installConfig = {
pnp: true,
};
app.addDependency('ember-source-channel-url', '1.1.0');
app.addDependency('resolve-package-path', 'link:' + path.join(__dirname, '..'));
app.files = {
'test.js':
'require("resolve-package-path")(process.argv[2], __dirname); console.log("success!");',
};
});

afterEach(function () {
app.dispose();
app.writeSync();
execa.sync('yarn', {
cwd: app.baseDir,
});
});

it('handles yarn pnp usage - package exists', function () {
let result = execa.sync('yarn', ['test', 'ember-source-channel-url'], {
cwd: app.baseDir,
});
afterEach(function () {
app.dispose();
});

expect(result.stdout.toString()).includes('found');
expect(result.exitCode).to.eql(0);
it('handles yarn pnp usage - package exists', function () {
let result = execa.sync('yarn', ['test', 'ember-source-channel-url'], {
cwd: app.baseDir,
});

it('handles yarn pnp usage - package missing', function () {
let result = execa.sync('yarn', ['test', 'some-non-existent-package'], {
cwd: app.baseDir,
reject: false,
});
expect(result.stdout.toString()).includes('success!');
});

expect(result.stdout.toString()).includes('not-found');
expect(result.exitCode).to.eql(1);
it('handles yarn pnp usage - package missing', function () {
let result = execa.sync('yarn', ['test', 'some-non-existent-package'], {
cwd: app.baseDir,
});

expect(result.stdout.toString()).includes('success!');
});
}
});

describe('findUpPackagePath', function () {
let tmpDir: string;
Expand Down