fix: sharding in combination with the --url cli option #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-halliday
commented
Aug 18, 2025
tsup.config.ts
Outdated
| @@ -3,7 +3,7 @@ import { defineConfig } from 'tsup'; | |||
| export default defineConfig([ | |||
| { | |||
| clean: true, | |||
| entry: ['./src/index.ts', './src/test-storybook.ts'], | |||
| entry: ['./src/index.ts', './src/test-storybook.ts', './src/config/jest-sequencer.ts'], | |||
There was a problem hiding this comment.
I struggled to get this to be usable in Jest config without building it and including it in the dist folder... Not sure if there's a way to avoid that with the way jest config wants to resolve a module.
matt-halliday
commented
Aug 18, 2025
matt-halliday
commented
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #577
What I did
This adds a custom Jest sequencer if the tests are running against an
index.jsonfile (in which case test files are written to a temporary directory), and sort them by test name, rather than default which uses the path.Checklist for Contributors
Manual testing
yarn test-storybook -u --browsers chromium --url=https://drei.pmnd.rs --shard=1/2yarn test-storybook -u --browsers chromium --url=https://drei.pmnd.rs --shard=2/2You will have coverage of all the components, not a random amount of them.
Documentation
Checklist for Maintainers
Make sure this PR contains one of the labels below:
Available labels
skip-release: Skip any releases, e.g., documentation only changes, CI config etc.patch: Upgrade patch version (e.g. 0.0.x)minor: Upgrade patch version (e.g. 0.x.0)major: Upgrade patch version (e.g. x.0.0)