Block Konbini and Blik payment methods with ConfirmationTokens in test mode #11756
+154
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following TDD approach, add failing tests that verify: - Konbini and Blik payment methods throw IllegalStateException in test mode - Konbini and Blik payment methods succeed in live mode These tests currently fail as the blocking logic has not been implemented yet. Related to MOBILESDK-4092 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Committed-By-Agent: claude
…t mode Add failIfUnsupportedPaymentMethod() function that throws IllegalStateException for Konbini and Blik payment methods when using test mode API keys. The block is enforced in both new and saved payment method flows. Live mode usage is allowed to enable production functionality while preventing test mode usage of payment methods not yet supported with confirmation tokens. Related to MOBILESDK-4092 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Committed-By-Agent: claude
Simplify Konbini and Blik blocking tests by using the existing helper function instead of manually creating interceptors. This reduces code duplication and improves maintainability. - Add isLiveMode parameter to helper that controls publishableKeyProvider - Use helper for all four test cases (test/live mode × Konbini/Blik) - Reduce each test by ~50% while maintaining the same test coverage 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Committed-By-Agent: claude
|
Diffuse output: APK |
amk-stripe
reviewed
Oct 16, 2025
...tripe/android/paymentelement/confirmation/intent/ConfirmationTokenConfirmationInterceptor.kt
Outdated
Show resolved
Hide resolved
| private fun failIfUnsupportedPaymentMethod(paymentMethodCode: String?) { | ||
| val unsupportedPaymentMethods = setOf("konbini", "blik") | ||
|
|
||
| if (paymentMethodCode in unsupportedPaymentMethods && !requestOptions.apiKeyIsLiveMode) { |
There was a problem hiding this comment.
What's the behavior in live mode? ie what is the user experience if they are trying to check out with Konbini + CTs in live mode?
There was a problem hiding this comment.
What is the best way to test that? If I simply remove the assertion and try in playground, it would look like this:
Screen_recording_20251016_221319.mp4
There was a problem hiding this comment.
I'll follow up on this on slack
...roid/paymentelement/confirmation/interceptor/ConfirmationTokenConfirmationInterceptorTest.kt
Outdated
Show resolved
Hide resolved
amk-stripe
previously approved these changes
Oct 17, 2025
| private fun failIfUnsupportedPaymentMethod(paymentMethodCode: String?) { | ||
| val unsupportedPaymentMethods = setOf("konbini", "blik") | ||
|
|
||
| if (paymentMethodCode in unsupportedPaymentMethods && !requestOptions.apiKeyIsLiveMode) { |
There was a problem hiding this comment.
I'll follow up on this on slack
# Conflicts: # paymentsheet/src/test/java/com/stripe/android/paymentelement/confirmation/interceptor/ConfirmationTokenConfirmationInterceptorTest.kt
amk-stripe
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Block Konbini and Blik payment methods when using confirmation tokens in test mode. These payment methods are not yet fully supported with confirmation tokens. By blocking them early in test mode, we help developers catch this issue during development rather than encountering errors in production.
Motivation
MOBILESDK-4092
Testing
Screenshots
Changelog