remove asm.S and neon.S from _SOURCES #479
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oreo639
force-pushed
the
fix-execstack-arm
branch
from
617af18 to
acbecb7
Compare
Previously asm.S and neon.S were getting assembled into object files and linked. While for asm.S, this doesn't cause any problems, neon.S never ends up including a .note.GNU-stack section resulting in the final library being marked as requiring executable stack. These files just define macros used by cpudetect.S and hevcdsp_qpel_neon.S so them getting assembled and linked individually doesn't seem intended.
oreo639
force-pushed
the
fix-execstack-arm
branch
from
acbecb7 to
58b8efb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously asm.S and neon.S were getting assembled into object files and linked. While for asm.S, this doesn't cause any problems, neon.S never ends up including a .note.GNU-stack section resulting in the final library being marked as requiring executable stack.
These files just define macros used by cpudetect.S and hevcdsp_qpel_neon.S so them getting assembled and linked individually doesn't seem intended.