- 
                Notifications
    
You must be signed in to change notification settings  - Fork 19
 
Aria attributes #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            betweenbrain
  wants to merge
  22
  commits into
  sumcumo:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
Guggenheim:aria-attributes
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Draft
                    Aria attributes #86
Changes from 19 commits
      Commits
    
    
            Show all changes
          
          
            22 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      3a450d7
              
                Change span to button to allow element to have focus
              
              
                betweenbrain 03fa142
              
                Adds dynamic open/close datepicker aria-label
              
              
                betweenbrain 32939f3
              
                Update test spec to not look for calendar button as a specific element
              
              
                betweenbrain a1bfb61
              
                Adds and implements button reset styles to maintain existing appearance
              
              
                betweenbrain b9c542e
              
                Set background to none to unset default styling
              
              
                betweenbrain 6c8b967
              
                Use button instead of span
              
              
                betweenbrain 19e9616
              
                Adds dynamic aria-label using LocaleDateString
              
              
                betweenbrain f3ea70d
              
                Use button instead of span, adds dynamic aria-label using LocaleDateS…
              
              
                betweenbrain 3c61064
              
                Use month instead of day for parameter
              
              
                betweenbrain 1b586e9
              
                Use button instead of span, adds dynamic aria-label using LocaleDateS…
              
              
                betweenbrain ebf4fd2
              
                Adds aria-expanded
              
              
                betweenbrain d6c963e
              
                Adds uid prop, consumed for aria-controls
              
              
                betweenbrain dfee9a5
              
                Fix uid prop type
              
              
                betweenbrain 9a81f79
              
                Implements previous and next aria-labels
              
              
                betweenbrain ce09c21
              
                Code formatting
              
              
                betweenbrain 014b93a
              
                Change prev and next buttons to buttons
              
              
                betweenbrain 19320e4
              
                Use background transparent instead of none
              
              
                betweenbrain 1aacaee
              
                Lint fixes
              
              
                betweenbrain 8c6e4e4
              
                Lint fixes
              
              
                betweenbrain e143b53
              
                Adds format prop and formatDate method
              
              
                betweenbrain f09273b
              
                Add format argument to Datepicker
              
              
                betweenbrain c21ccfc
              
                Implement use of format for aria-label
              
              
                betweenbrain File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| @mixin button-reset { | ||
| background: transparent; | ||
| border: none; | ||
| margin: 0; | ||
| overflow: visible; | ||
| padding: 0; | ||
| width: auto; | ||
| 
     | 
||
| /* Inherit font & color from ancestor */ | ||
| color: inherit; | ||
| font: inherit; | ||
| 
     | 
||
| /* Normalize `line-height`. Cannot be changed from `normal` in Firefox 4+. */ | ||
| line-height: normal; | ||
| 
     | 
||
| /* Corrects font smoothing for webkit */ | ||
| -webkit-font-smoothing: inherit; | ||
| -moz-osx-font-smoothing: inherit; | ||
| 
     | 
||
| /* Corrects inability to style clickable `input` types in iOS */ | ||
| -webkit-appearance: none; | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.