Skip to content

Conversation

hardys
Copy link
Contributor

@hardys hardys commented Sep 19, 2024

To align with https://docs.rke2.io/networking/multus_sriov#using-multus-with-cilium

In the long term it may be desirable to set this automatically via the RKE2 CAPI provider, but this seems like the simplest way to achieve the recommended configuration for now.

@hardys hardys marked this pull request as draft September 19, 2024 16:04
@hardys hardys requested a review from alknopfler September 20, 2024 08:05
@hardys
Copy link
Contributor Author

hardys commented Sep 20, 2024

@alknopfler two questions when you get a moment:

  • I think this should be included in all manifests, not just airgap right?
  • If this should always be set for cilium+multus perhaps we should enable this via the RKE2 CAPI provider in future, what do you think?

@alknopfler
Copy link
Contributor

yes, but I've modified in #12 the following scenarios in order to have more variety of use cases:

  • Airgap with calico + multus because we've got a lot of scripts inside the ignition/combustion part
  • Single node with calico + multus -> same reason
  • Multi node cilium + multus -> I will add this code

makes sense?

@alknopfler
Copy link
Contributor

@hardys is enough with my previous comment to close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants