Skip to content

Conversation

@HoKim98
Copy link
Contributor

@HoKim98 HoKim98 commented Feb 17, 2025

I don't think there is a better repository for deploying KubeVirt with Helm.

This PR is part of the hardening work for KubeVirt and CDI Operator. Along with #161, this PR allows custom values ​​for affinity and resources. This allows Ops to design more appropriate resource placement for their own environments. The default is AS-IS.

During making this PR, I found that the previous affinity configuration for CDI Operator was incorrect. It should be set to podAntiAffinity instead of podAffinity like KubeVirt Operator so that the operator pod can be distributed correctly across multiple nodes.

@HoKim98 HoKim98 force-pushed the kubevirt/feat/custom-affinity branch from af0e155 to fc3c64e Compare February 17, 2025 04:24
@hardys hardys requested a review from atanasdinov February 17, 2025 15:02
@atanasdinov
Copy link
Contributor

atanasdinov commented Feb 20, 2025

Thanks for this submission. I might look into splitting this up in the respective chart builds for the next version.

Quick question, what is the benefit of the following?

think this is a good alternative for users who don't want to install Operator and Resources at the same time.

If these are disabled, then we'd only have the operators deployed since they start the installation once the resources are created on the cluster.

@HoKim98 HoKim98 force-pushed the kubevirt/feat/custom-affinity branch from fc3c64e to 43ca407 Compare March 5, 2025 14:43
@HoKim98 HoKim98 force-pushed the kubevirt/feat/custom-affinity branch from 43ca407 to 228bca0 Compare March 5, 2025 14:46
@HoKim98
Copy link
Contributor Author

HoKim98 commented Mar 5, 2025

Ok, I agree that it's not common to deploy just the operator. I reverted the change.

Copy link
Contributor

@atanasdinov atanasdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During making this PR, I found that the previous affinity configuration for CDI Operator was incorrect. It should be set to podAntiAffinity instead of podAffinity like KubeVirt Operator so that the operator pod can be distributed correctly across multiple nodes.

The values are picked from the upstream manifests. I'll look into this further while preparing the next chart version.

Thanks for the contribution!

@atanasdinov atanasdinov merged commit 50a00b6 into suse-edge:main Mar 19, 2025
1 check failed
@atanasdinov atanasdinov mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants