kubevirt: add support for extra annotations #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanasdinov
reviewed
Jun 20, 2025
There was a problem hiding this comment.
Thanks for the contribution @HoKim98.
In order to make the CI happy and allow for the changes to be merged, we have to go through the process of bumping the package and generating a newer version of the chart.
Could you please bump Chart.yaml and package.yaml and then run the Makefile targets:
make chartsmake html
Feel free to take a look at how it's done in #198 as inspiration.
Signed-off-by: Ho Kim <[email protected]>
Signed-off-by: Ho Kim <[email protected]>
HoKim98
force-pushed
the
feat/kubevirt-custom-annotations
branch
from
2a18cb1 to
c043b66
Compare
|
Thank you for the feedback @atanasdinov I bumped the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to edit annotations and labels of KubeVirt CR.
It's required to enable SMT (Simultaneous MultiThreading) with static kubelet CPUManager policy and
isolateEmulatorThread.NOTE: https://kubevirt.io/user-guide/compute/dedicated_cpu_resources/#compute-nodes-with-smt-enabled