-
Notifications
You must be signed in to change notification settings - Fork 29
docs: restructure user documentation #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: restructure user documentation #622
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
=======================================
Coverage 77.26% 77.26%
=======================================
Files 11 11
Lines 1267 1267
=======================================
Hits 979 979
Misses 258 258
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e32106b
to
0371b0c
Compare
4a27a8b
to
907e4a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restructures the user-facing documentation from scattered docs/user-guides/
files into an organized guide structure with clear installation, usage, and reference sections. The restructuring improves documentation discoverability and provides clear paths for both Kubernetes and OpenShift users.
Key changes:
- Creates comprehensive installation guides for Kubernetes and OpenShift platforms
- Reorganizes usage guides with detailed PowerMonitor configuration and monitoring setup
- Consolidates API documentation and adds complete uninstallation procedures
Reviewed Changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
docs/user/installation/*.md | New installation guides for Kubernetes, OpenShift, and monitoring stack setup |
docs/user/guides/*.md | Comprehensive usage guides covering PowerMonitor, configuration, Grafana, validation, upgrading, and troubleshooting |
docs/user/reference/*.md | Reference documentation including API specs and uninstallation procedures |
docs/user/README.md | New user documentation index with clear navigation and quick starts |
hack/dashboard/openshift/README.md | Updated reference path to developer documentation |
docs/user/configuring-kepler.md | Updated cross-references to new documentation structure |
README.md | Updated with new documentation structure and improved quick start guides |
Makefile, .pre-commit-config.yaml | Updated tooling paths for API documentation generation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
6f76401
to
3b95408
Compare
docs/user/guides/configuration.md
Outdated
- Override default Kepler settings | ||
- Provide environment-specific configuration | ||
|
||
## Configuration Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this to much info?
|
||
This script automatically: | ||
|
||
1. Creates a Grafana instance in the `kepler-operator` namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really this is wrong
3. Imports Kepler dashboards | ||
4. Sets up necessary RBAC permissions | ||
|
||
### Access Grafana on OpenShift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need updation
▼ | ||
┌─────────────────┐ | ||
│ ServiceMonitor │ | ||
│ (kepler) │ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
power-monitor ns
8fc74c0
to
0c56383
Compare
7450331
to
16b1e3f
Compare
Signed-off-by: Sunil Thaha <[email protected]>
16b1e3f
to
68bf086
Compare
docs/user/guides/troubleshooting.md
Outdated
**Check for common error patterns**: | ||
|
||
```bash | ||
kubectl logs -n kepler-operator deployment/kepler-operator-controller-manager | grep -i error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl logs -n kepler-operator deployment/kepler-operator-controller-manager | grep -i error | |
kubectl logs -n kepler-operator deployment/kepler-operator-controller | grep -i error |
docs/user/guides/troubleshooting.md
Outdated
|
||
```bash | ||
kubectl get powermonitor -A | ||
kubectl describe powermonitor <name> -n <namespace> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we require specifying namespace?
docs/user/guides/troubleshooting.md
Outdated
kubectl edit powermonitor <name> -n <namespace> | ||
``` | ||
|
||
1. **Namespace doesn't exist**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this handled by operator itself?
docs/user/guides/troubleshooting.md
Outdated
Error: failed to read RAPL: no such file or directory | ||
``` | ||
|
||
**Solution**: Enable fake CPU meter via ConfigMap: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This need updation
docs/user/guides/troubleshooting.md
Outdated
Error: failed to access /sys/class/powercap: permission denied | ||
``` | ||
**Solution**: Verify Kepler is running with privileged security context (automatically configured by operator). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't operator responsible for this as well?
docs/user/guides/troubleshooting.md
Outdated
|
||
```bash | ||
# Operator logs | ||
kubectl logs -n kepler-operator deployment/kepler-operator-controller-manager > operator-logs.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl logs -n kepler-operator deployment/kepler-operator-controller-manager > operator-logs.txt | |
kubectl logs -n kepler-operator deployment/kepler-operator-controller > operator-logs.txt |
docs/user/installation/openshift.md
Outdated
Expected output: | ||
|
||
```text | ||
kepler-operator-controller-manager-xxxxx-yyyyy 2/2 Running 0 1m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kepler-operator-controller-manager-xxxxx-yyyyy 2/2 Running 0 1m | |
kepler-operator-controller-xxxxx-yyyyy 2/2 Running 0 1m |
kubectl delete crd keplers.kepler.system.sustainable.computing.io | ||
kubectl delete crd keplersinternals.kepler.system.sustainable.computing.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No Kepler and Kepler Internals
docs/user/configuring-kepler.md
Outdated
|
||
```bash | ||
# For Kubernetes (Helm installation) | ||
kubectl logs -n kepler-operator deployment/kepler-operator-controller-manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl logs -n kepler-operator deployment/kepler-operator-controller-manager | |
kubectl logs -n kepler-operator deployment/kepler-operator-controller |
To run the operator locally outside the cluster: | ||
Get Kepler up and running in minutes. For comprehensive installation instructions, prerequisites, configuration options, and troubleshooting, see the **[Kubernetes Installation Guide](docs/user/installation/kubernetes.md)**. | ||
|
||
```sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this repetition of user guide for installation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have refactored the installation docs.
- README.md quick and dirty
- installation/k8s.md : detailed
- monitoring-k8s: setting up prometheus & grafana
make cluster-up | ||
|
||
# Run operator locally | ||
make run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make run | |
make run ENABLE_WEBHOOKS=false |
?
8ebdba0
to
8b3aa2e
Compare
Reorganize user-facing documentation into a better guide structure: - Move API reference to docs/user/reference/api.md - Create new user guide sections: installation, guides, reference - Replace scattered user-guides with organized documentation covering: - Installation (Kubernetes/OpenShift/monitoring stack setup) - Usage guides (PowerMonitor, configuration, Grafana, validation) - Reference (API docs, troubleshooting, uninstallation) - Update README.md with new documentation structure and quick starts - Update tooling paths (.pre-commit-config.yaml, Makefile) - Remove deprecated grafana-deployment.md and assets (moved to user/guides) This restructure improves documentation discoverability and provides clear installation and usage paths for both Kubernetes and OpenShift users. Signed-off-by: Sunil Thaha <[email protected]>
8b3aa2e
to
8f2ae48
Compare
Reorganize user-facing documentation into a better guide structure:
This restructure improves documentation discoverability and provides clear installation and usage paths for both Kubernetes and OpenShift users.