Define _POSIX_C_SOURCE globally and detect supported warnings #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other Sway projects have switched to this approach.
Let's not require the C compiler to support specific warnings, especially if half the flags are used to turn off the warnings anyways.
|
fwiw, on OpenBSD i had to revert this/drop the define from meson.build, as having POSIX_SOURCE defined disables |
|
#325 is not merged. |
bob-beck
pushed a commit
to openbsd/ports
that referenced
this pull request
Apr 15, 2025
see https://github.com/swaywm/swaylock/releases/tag/v1.8.1 and https://github.com/swaywm/swaylock/releases/tag/v1.8.2 drop -D_POSIX_C_SOURCE=200809L from CFLAGS as it disables __BSD_VISIBLE which hides explicit_bzero(). cf swaywm/swaylock#402
i know, it stalled. I'm just saying that this PR creates issues with it :) |
The OpenBSD backend should use |
|
@kennylevinsen thanks, that also works. I'll try to unstall #325 someday.. |
sthen
pushed a commit
to sthen/ports
that referenced
this pull request
Apr 16, 2025
see https://github.com/swaywm/swaylock/releases/tag/v1.8.1 and https://github.com/swaywm/swaylock/releases/tag/v1.8.2 drop -D_POSIX_C_SOURCE=200809L from CFLAGS as it disables __BSD_VISIBLE which hides explicit_bzero(). cf swaywm/swaylock#402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define _POSIX_C_SOURCE globally
Other Sway projects have switched to this approach.
build: use cc.get_supported_arguments() for warnings
Let's not require the C compiler to support specific warnings,
especially if half the flags are used to turn off the warnings
anyways.