Skip to content

Conversation

@tmorrell
Copy link
Contributor

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
The range_overlap example stops before giving a final solution, which is annoying if you're teaching from the curriculum. The assertions also change order for no particular reason.

I fix the order of the assertions, and add the complete working function.

If any relevant discussions have taken place elsewhere, please provide links to these.
Replacing this example has discussed for years #979, but there hasn't been a good proposal. This PR just makes the existing curriculum more useful, and it's fine if it gets replaced at some point in the future.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at [email protected].

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-inflammation/compare/md-outputs..md-outputs-PR-1109

The following changes were observed in the rendered markdown documents:

 10-defensive.md | 80 +++++++++++++++++++++++++++++++++++++++++++++++++--------
 md5sum.txt      |  2 +-
 2 files changed, 70 insertions(+), 12 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-10-23 22:18:48 +0000

github-actions bot pushed a commit that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant