chore: fix "lint" script & add "lint-fix" script #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: - Windows compatibility - cover more files (e.g. files in cypress dir & root dir)
limonte
approved these changes
Sep 2, 2022
|
Are you maybe planning to tackle #192? I also have it on my todo list, TBH I didn't like the quality of the code in the external PR. |
|
@limonte yeah, I found the logic hard to follow. I reviewed again yesterday and still do. I think it's inherently complicated, but also I think it could probably be improved. Would need to wrap my head around it first lol. It's on my todo list as well but not sure when I'll get to it, so go ahead if you find time before me. I made a PR to add tests, could use your review: omerman#1 |
|
🎉 This PR is included in version 5.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
limonte
pushed a commit
that referenced
this pull request
Nov 6, 2022
Fixes: - Windows compatibility - cover more files (e.g. files in cypress dir & root dir)
limonte
pushed a commit
that referenced
this pull request
Nov 7, 2022
Fixes: - Windows compatibility - cover more files (e.g. files in cypress dir & root dir)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: