Use defaultRecorderBuckets for Histogram #75
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh this has become quite stale, sorry about this -- it seems to be resolved in other ways on current main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I've not updated tests (mostly because I entirely made this change on GitHub) but we totally should to prevent regression. Created this branch so I can do a quick validation by pointing my project to this branch.
Motivation and Context
Fixes #74
Description
Pass the user-provided default for the buckets to the create histogram function. This value defaults to the same value which the function defaults to - so unless the user has overridden the default buckets value, this change will not impact existing code.