[-Wunsafe-buffer-usage] Allow passing anything to void *__single #11167
+35
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykstefanski
requested review from
delcypher,
ziqingluo-90,
hnrklssn and
rapidsna
patrykstefanski
added
the
clang:bounds-safety
patrykstefanski
force-pushed
the
eng/pstefanski/PR-156007256
branch
from
52102bf to
1974862
Compare
|
LGTM! |
ziqingluo-90
approved these changes
Aug 19, 2025
|
Just curious, does BoundsSafety allow casting |
BoundsSafety assumes that `void *__single` cannot be dereferenced and allows assigning anything to `void *__single`. This commit ports this behavior to C++ interop. rdar://156007256
patrykstefanski
force-pushed
the
eng/pstefanski/PR-156007256
branch
from
1974862 to
a2ee8b5
Compare
|
@swift-ci test llvm |
Yes, apparently this it not a bounds-safety problem, but a type-safety one. |
|
Unrelated tests are failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BoundsSafety assumes that
void *__singlecannot be dereferenced and allows assigning anything tovoid *__single. This commit ports this behavior to C++ interop.rdar://156007256