Add minimum access level as a setting for the symbol graph extraction #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcgee1024
requested review from
aciidgh,
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci please test |
owenv
reviewed
Sep 10, 2025
| @@ -2757,6 +2759,18 @@ public enum LinkerDriverChoice: String, Equatable, Hashable, EnumerationMacroTyp | |||
| case auto | |||
| } | |||
|
|
|||
| public enum DoccMinimumAccessLevel: String, Equatable, Hashable, EnumerationMacroType { | |||
There was a problem hiding this comment.
You may need to add a case to the switch in EnumBuildOptionType.declareMacro for this enum type too. It might be nice to have a test in DocumentationTaskConstructionTests that the flag is being passed through correctly
|
@swift-ci please test |
|
@swift-ci please test |
owenv
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting wasn't present before, so this is added as a build setting enumeration with
a special "none" default value that performs the fallback that is based on the kind of the
module.
Remove the swift compiler feature checks for the previously added settings since the
feature is unrelated to them.