Test: simplify the test configuration #515
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the compatibility paths in the test infrastructure. Foundation and dispatch have had evolved over the years. Remove the compatibility assuming that something within the past few years is used to build. This is now more reasonable given that the Foundation and dispatch dependencies have been made optional - this allows building XCTest against a SDK. This also reduces the setup for Windows to a very trivial skeleton of just passing along SDKROOT. This enables the windows build to run the test suite against the SDKROOT that has been built up which allows us to swap to the new runtime implementation.
compnerd
requested review from
stmontgomery,
grynspan,
jerryjrchen and
briancroom
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the compatibility paths in the test infrastructure. Foundation and dispatch have had evolved over the years. Remove the compatibility assuming that something within the past few years is used to build. This is now more reasonable given that the Foundation and dispatch dependencies have been made optional - this allows building XCTest against a SDK.
This also reduces the setup for Windows to a very trivial skeleton of just passing along SDKROOT. This enables the windows build to run the test suite against the SDKROOT that has been built up which allows us to swap to the new runtime implementation.