Skip to content

Revise Windows image attachments to match the draft API proposal. #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2025
Merged

Revise Windows image attachments to match the draft API proposal. #1268

merged 2 commits into from
Aug 15, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Aug 14, 2025 •
edited
Loading

This PR tweaks the Windows image attachments API to match what is proposed in swiftlang/swift-evolution#2940.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Revise Windows image attachments to match the draft API proposal.
3be9c61 
This PR tweaks the Windows image attachments API to match what is proposed in
swiftlang/swift-evolution#2940.
@grynspan grynspan added this to the Swift 6.x (main) milestone Aug 14, 2025
@grynspan grynspan self-assigned this Aug 14, 2025
@grynspan grynspan added the enhancement New feature or request label Aug 14, 2025
@grynspan grynspan requested a review from stmontgomery as a code owner August 14, 2025 16:44
@grynspan grynspan added the windows 🪟 Windows support label Aug 14, 2025
@grynspan grynspan added darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support public-api Affects public API attachments/activities 🖇️ Work related to attachments and/or activities labels Aug 14, 2025
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan added the self-reviewed PR was self-reviewed by a code owner label Aug 15, 2025
@grynspan grynspan removed the self-reviewed PR was self-reviewed by a code owner label Aug 15, 2025
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test Windows

@grynspan grynspan merged commit 0b48b60 into main Aug 15, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/align-windows-attachments-with-draft-proposal branch August 15, 2025 17:09
@grynspan grynspan added the image-attachments 📸 Work related to image attachments label Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
attachments/activities 🖇️ Work related to attachments and/or activities darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support enhancement New feature or request image-attachments 📸 Work related to image attachments public-api Affects public API windows 🪟 Windows support
Projects
None yet
Milestone
Swift 6.x (main)
Development

Successfully merging this pull request may close these issues.
2 participants
@grynspan @stmontgomery