[Sema] Clean up extension binding a little #83777
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I missed this in my previous patch that moved extension binding until after we've mutated the AST for IDE inspection, this ad-hoc extension binding logic is no longer necessary.
This will mainly be useful once extension binding is fully requestified, but even now it's a good idea to ensure module loading isn't kicking name lookup.
hamishknight
requested review from
hborla,
slavapestov,
xedin,
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
|
@swift-ci please SourceKit stress test https://ci.swift.org/job/swift-PR-macos-with-sourcekit-stress-tester/431/ |
- Turn `BindExtensionsForIDEInspectionRequest` into the main extension binding request. - Change `ExtendedNominalRequest` such that it's no longer what extension binding calls into to do the name lookup, instead it calls directly into `computeExtendedNominal`. `getExtendedNominal` can then be the entrypoint for `ExtendedNominalRequest` and assumes that extension binding has already run. This avoids needing to fake the dependency relationship in the DeclChecker.
hamishknight
force-pushed
the
ext-cleanup
branch
from
b5609b4 to
6c649cb
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BindExtensionsForIDEInspectionRequestinto the main extension binding request.ExtendedNominalRequestsuch that it's no longer what extension binding calls into to do the name lookup, instead it calls directly intocomputeExtendedNominal.getExtendedNominalcan then be the entrypoint forExtendedNominalRequestand assumes that extension binding has already run. This avoids needing to fake the dependency relationship in the DeclChecker.