Add OS information that supports riscv64 #5034
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @pengjunjie2100, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request extends the project's build system to officially support the riscv64 architecture. It integrates new Makefile rules to enable compilation and package generation for various contemporary Linux distributions on this platform, based on publicly available information regarding supported OS versions.
Highlights
- New Architecture Support: This PR introduces comprehensive build targets and package listing rules specifically for the
riscv64architecture within theMakefile. - Expanded OS Compatibility: Support for
riscv64compilation is added across several Linux distributions and their specific versions, including Almalinux 10, CentOS 10, Debian 13, Fedora 42, OpenSUSE 16, and Ubuntu 24/25.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds build targets for the riscv64 architecture, defining supported operating systems. The changes are consistent with the existing arm64 targets. I've found one issue where a newly defined target for AlmaLinux on riscv64 is not included in the main package build target, which would prevent it from being built. My feedback includes a suggestion to fix this.
| @${MAKE} -nk arm64-packages 2>/dev/null | grep -Po '(?<=binaries/)proxysql\S+$$' | ||
|
|
||
| riscv64-%: SYS_ARCH := riscv64 | ||
| riscv64-packages: riscv64-centos riscv64-debian riscv64-ubuntu riscv64-fedora riscv64-opensuse |
There was a problem hiding this comment.
The riscv64-almalinux target is defined on the next line, but it's not included as a prerequisite for the riscv64-packages target. This means that make riscv64-packages will not trigger a build for AlmaLinux on riscv64.
To ensure all supported riscv64 distributions are built, please add riscv64-almalinux to the list of prerequisites.
riscv64-packages: riscv64-almalinux riscv64-centos riscv64-debian riscv64-ubuntu riscv64-fedora riscv64-opensuse
|
Can one of the admins verify this patch? |
|
This PR collects and add supported operating system versions for riscv64 architecture compilation based on publicly available information.