Allow only galera servers in online status #5106
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Gonlo2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical oversight in how ProxySQL manages Galera cluster server statuses. It rectifies an issue where read servers were not consistently checked for an "online" status, unlike write servers. By standardizing this check, the change enhances the robustness and recovery capabilities of ProxySQL when dealing with dynamic Galera cluster environments, preventing the use of offline nodes.
Highlights
- Galera Server Status Checks: Ensures that both writer and reader Galera servers are only considered if their status is "online" (status 0) during the update_galera_set_writer process, aligning the checks for both types of hostgroups.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a bug where Galera reader nodes were considered available regardless of their online status. The change ensures that only servers with an 'ONLINE' status (status=0) are considered for both writer and reader roles. Additionally, the code has been refactored for better readability and conciseness, using a more modern loop structure and logical assignments. The fix is correct and improves the robustness of Galera hostgroup management. Well done.
|
This PR fix use non online servers for galera checks.
A clear description of the issue
Currently, it is not checked whether a galera read server is online, although this does happen with write servers. This PR is a rebase of some changes included in my #3063 PR but using the latest version of ProxySQL.
ProxySQL version
v3.0.2
The steps to reproduce the issue
Since this is an rebase of some changes that I made about 5 years ago, I don't remember in which cases this error occurred but it surely prevented ProxySQL from recovering if any node in the cluster had gone down and then back to up.