Modernize #7
Open
Modernize #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New in systemd 257
This is needed to use `GIO.Notification`, the replacement for `Gtk.StatusIcon`.
This separates the watching for things to send notifications from the handling of actual requests.
I've probably done enough surgery to warrant it at this point.
|
One more thing to do here: if the |
|
Is this ready? |
|
No, the "rescind the notification on deletion" is not implemented. But I suppose an issue could be raised for that. Would you mind testing it as well? My use case is quite narrow and it works there, but I'm sure there are other cases that may have issues. |
|
Thanks for the info! Sure, I plan to test this GTK4 port in upcoming weeks (after next week's vacation). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTK4 port. Also now supports the system and user password request directories.