-
Notifications
You must be signed in to change notification settings - Fork 527
refactor: drop any
in tuiDirectiveBinding
#11751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tests completed successfully ✅Good job 🔥 |
66aac5f
to
bdb4ac7
Compare
View your CI Pipeline Execution ↗ for commit bdb4ac7
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the tuiDirectiveBinding
function to eliminate the use of the any
type, improving type safety throughout the codebase. The changes introduce proper TypeScript type definitions and constraints while maintaining the same functionality.
Key changes:
- Introduces new type aliases (
Result
,Directive
) to replaceany
usage - Adds proper type imports (
EventEmitter
,OnChanges
) - Implements type assertions and constraints for better type safety
Visit the preview URL for this PR (updated for commit bdb4ac7): https://taiga-previews-demo--pr11751-splincode-directive-bindi-ufnglrjs.web.app (expires Sat, 23 Aug 2025 15:01:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
BundleMonUnchanged files (5)
Total files change +2B 0% Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
Playwright test resultsDetails
Skipped testschromium › tests/core/dropdown/dropdown.pw.spec.ts › Dropdown › Esc -> Hosted Dropdown |
No description provided.