Skip to content

refactor: drop any in tuiDirectiveBinding #11751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

splincode
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings August 22, 2025 14:55
@splincode splincode requested a review from a team as a code owner August 22, 2025 14:55
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team August 22, 2025 14:55
Copy link
Contributor

github-actions bot commented Aug 22, 2025

Tests completed successfully ✅

Good job 🔥

@splincode splincode force-pushed the splincode/directive-binding branch from 66aac5f to bdb4ac7 Compare August 22, 2025 14:56
Copy link

nx-cloud bot commented Aug 22, 2025

View your CI Pipeline Execution ↗ for commit bdb4ac7

Command Status Duration Result
nx run-many --target test --all --output-style=... ✅ Succeeded 4m 39s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-22 15:24:39 UTC

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the tuiDirectiveBinding function to eliminate the use of the any type, improving type safety throughout the codebase. The changes introduce proper TypeScript type definitions and constraints while maintaining the same functionality.

Key changes:

  • Introduces new type aliases (Result, Directive) to replace any usage
  • Adds proper type imports (EventEmitter, OnChanges)
  • Implements type assertions and constraints for better type safety

Copy link
Contributor

Visit the preview URL for this PR (updated for commit bdb4ac7):

https://taiga-previews-demo--pr11751-splincode-directive-bindi-ufnglrjs.web.app

(expires Sat, 23 Aug 2025 15:01:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Aug 22, 2025

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
351.3KB +10%
demo/browser/vendor.(hash).js
261.83KB +10%
demo/browser/runtime.(hash).js
53.38KB +10%
demo/browser/styles.(hash).css
22.46KB +10%
demo/browser/polyfills.(hash).js
11.16KB +10%

Total files change +2B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
9.81MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

Playwright test results

passed  1496 passed
skipped  5 skipped

Details

report  Open report ↗︎
stats  1501 tests across 81 suites
duration  15 minutes, 32 seconds
commit  bdb4ac7

Skipped tests

chromium › tests/core/dropdown/dropdown.pw.spec.ts › Dropdown › Esc -> Hosted Dropdown
chromium › tests/demo/source-code-link.pw.spec.ts › Source code button › /variables
chromium › tests/demo/source-code-link.pw.spec.ts › Source code button › /appearances
chromium › tests/demo/source-code-link.pw.spec.ts › Source code button › /portals
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › non-erasable minus (as [prefix]) for [max] <= 0 › forbids to enter more minuses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant