Skip to content

Conversation

qevolg
Copy link
Contributor

@qevolg qevolg commented Sep 8, 2025

Description

Support multi-process log and renamed to taoswslog

Jira: https://jira.taosdata.com:18080/browse/TD-37794

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@qevolg qevolg requested a review from Copilot September 8, 2025 02:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates log file naming conventions to use the 'taoswslog' prefix instead of 'taoslog', aligning with the WebSocket logging context.

  • Replaces all constants, function implementations, and test cases to use 'taoswslog' prefix
  • Updates regex patterns for compressed file parsing to match the new naming scheme
  • Maintains backward compatibility for file rotation and compression functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 90.93656% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.86%. Comparing base (0c9b05a) to head (da8526c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
taos-log/src/writer.rs 89.52% 22 Missing ⚠️
taos-query/src/common/raw/rows.rs 0.00% 2 Missing ⚠️
taos-query/src/common/raw/meta.rs 50.00% 1 Missing ⚠️
taos-query/src/common/raw/mod.rs 85.71% 1 Missing ⚠️
taos-query/src/common/raw/views/geometry_view.rs 66.66% 1 Missing ⚠️
taos-query/src/common/raw/views/var_char_view.rs 66.66% 1 Missing ⚠️
taos-query/src/common/raw/views/varbinary_view.rs 66.66% 1 Missing ⚠️
taos-query/src/prelude.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   82.63%   80.86%   -1.78%     
==========================================
  Files         117      115       -2     
  Lines       56703    50134    -6569     
==========================================
- Hits        46857    40539    -6318     
+ Misses       9846     9595     -251     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qevolg qevolg changed the title fix: update log file naming conventions to use 'taoswslog' prefix enh: support multi-process log and renamed to taoswslog Sep 11, 2025
@qevolg qevolg requested a review from Copilot September 11, 2025 00:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 54 out of 54 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zitsen zitsen merged commit a5e6058 into main Sep 15, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants