Skip to content

Conversation

qevolg
Copy link
Contributor

@qevolg qevolg commented Sep 11, 2025

Description

Optimize c ws stmt2

Jira: https://jira.taosdata.com:18080/browse/TD-34259

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 95.85799% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.62%. Comparing base (0e47990) to head (29d435e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
taos-ws-sys/src/ws/stmt2.rs 96.03% 13 Missing ⚠️
taos-ws/src/stmt2/mod.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   82.64%   82.62%   -0.02%     
==========================================
  Files         117      117              
  Lines       56734    56930     +196     
==========================================
+ Hits        46886    47040     +154     
- Misses       9848     9890      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qevolg qevolg requested a review from Copilot September 17, 2025 02:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the C WebSocket statement 2 (stmt2) implementation by replacing high-level parameter binding with direct byte serialization for better performance.

  • Replaces high-level Value and ColumnView based parameter binding with direct byte serialization
  • Introduces manual binary protocol encoding to avoid object allocation overhead
  • Adds new public APIs for direct byte binding and statement ID access

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

File Description
taos-ws/src/stmt2/mod.rs Renames internal method and exposes new public APIs for byte binding and statement ID access
taos-ws-sys/src/ws/stmt2.rs Major refactor replacing parameter conversion with direct byte serialization and binary protocol encoding
taos-ws-sys/Cargo.toml Adds byteorder dependency for binary data encoding
taos-query/src/stmt/mod.rs Consolidates imports for cleaner module organization

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@qevolg qevolg marked this pull request as ready for review September 17, 2025 02:47
@zitsen zitsen merged commit 56f7766 into main Sep 18, 2025
5 checks passed
@zitsen zitsen deleted the enh/TD-34259 branch September 18, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants