Write log messages from the daemon to a file #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this code to help me do a high-level look into #20
(unfortunately, that's not something I'm going to be able to fix myself, at least without some guidance).The CLI has a
--logoption, but as far as I could tell, the.tsimp/daemon/logfile wasn't being written to (though it contained a printed exception on my system, somehow).This PR makes log operations performed in the daemon get written to the log file rather than
stderr, which probably isn't hooked up to anything.We may want to consider using a proper logging library in the future, as this code doesn't do log rotations or the like.