Switch testing to JDK17 #188
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress toward #186
Leave PR events for comments and whatnot
|
I'm able to get tests to pass locally when using JDK17 and Spark 3.5.1 but not JDK17 with Spark 2.3.4. This is a pretty solid death knell for 2.3.4 in our world and means we're closer to #186 than I thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress toward #186
This may not work OOTB, because I don't know how well the Spark 2.3 path will
work, if at all. If it doesn't, I might just rip it out since we want to move
off of that ancient Spark version to satisfy #186 in its entirety.