Skip to content

Conversation

nitzanfarhi
Copy link

When the code in parser.py:70 is called:

 commit['message'] = "\n".join(
        parse_message_line(msgline)
        for msgline in
        parts['message'].splitlines()
    )

and parse_message_line is returned as None, and exception is thrown.
The solution was simple, swap None with newline.

@tarmstrong
Copy link
Owner

I haven't looked at this code in over a decade but as far as I can tell there shouldn't be an exception due to Nones getting filtered out here: https://github.com/tarmstrong/git2json/blob/master/git2json/parser.py#L79

Do you have an example exception?

@nitzanfarhi
Copy link
Author

nitzanfarhi commented Sep 26, 2024

It seems like I have an older version, I'll use the master instead of pip. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants