Skip to content

fix: exclude pending PipelineRuns from tekton_pipelines_controller_running_pipelineruns metric #8951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

fix: exclude pending PipelineRuns from tekton_pipelines_controller_running_pipelineruns metric #8951

merged 1 commit into from
Aug 19, 2025

Conversation

divyansh42
Copy link
Member

@divyansh42 divyansh42 commented Aug 6, 2025 •
edited
Loading

Changes

The running_pipelineruns metric incorrectly counted pending PipelineRuns as running.
Add !pr.IsPending() check to exclude them.

Fixes #8949

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Fixed tekton_pipelines_controller_running_pipelineruns metric to exclude pending PipelineRuns, it now counts only running PipelineRuns

@divyansh42
fix: exclude pending PipelineRuns from tekton_pipelines_controller_ru…
bebb679 
…nning_pipelineruns metric

The running_pipelineruns metric incorrectly counted pending PipelineRuns
as running. Add !pr.IsPending() check to exclude them.

Fixes tektoncd#8949

Signed-off-by: divyansh42 <[email protected]>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 6, 2025
@tekton-robot tekton-robot requested review from abayer and dibyom August 6, 2025 10:47
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 6, 2025
@divyansh42
Copy link
Member Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 6, 2025
@vdemeester
Copy link
Member

/retest

@divyansh42
Copy link
Member Author

/cc @vdemeester @waveywaves

@khrm
Copy link
Contributor

khrm commented Aug 11, 2025

/hold

Let's not merge this before #8933

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2025
@khrm
Copy link
Contributor

khrm commented Aug 19, 2025

/hold cancel Let's merge this before that.

@vdemeester
Copy link
Member

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2025
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
khrm
khrm reviewed Aug 19, 2025
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waveywaves This PR looks good. Can we merge this today?

waveywaves
waveywaves approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@waveywaves waveywaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [vdemeester,waveywaves]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 08196b5 into tektoncd:main Aug 19, 2025
47 of 50 checks passed
@divyansh42
Copy link
Member Author

/cherry-pick release-1.0.x

@tekton-robot
Copy link
Collaborator

@divyansh42: cannot checkout release-1.0.x: error checking out release-1.0.x: exit status 1. output: error: pathspec 'release-1.0.x' did not match any file(s) known to git

In response to this:

/cherry-pick release-1.0.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@divyansh42
Copy link
Member Author

/cherry-pick release-v1.0.x

@divyansh42 divyansh42 deleted the issue-8949 branch August 20, 2025 05:48
@tekton-robot
Copy link
Collaborator

@divyansh42: new pull request created: #8979

In response to this:

/cherry-pick release-v1.0.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Aug 20, 2025
Merged
@divyansh42
Copy link
Member Author

/cherry-pick release-1.3.x

@divyansh42
Copy link
Member Author

/cherry-pick release-v1.3.x

@tekton-robot
Copy link
Collaborator

@divyansh42: cannot checkout release-1.3.x: error checking out release-1.3.x: exit status 1. output: error: pathspec 'release-1.3.x' did not match any file(s) known to git

In response to this:

/cherry-pick release-1.3.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

@divyansh42: new pull request created: #8980

In response to this:

/cherry-pick release-v1.3.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Aug 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@waveywaves waveywaves waveywaves approved these changes

@abayer abayer Awaiting requested review from abayer

@dibyom dibyom Awaiting requested review from dibyom

+1 more reviewer

@khrm khrm khrm left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@waveywaves waveywaves

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metric tekton_pipelines_controller_running_pipelineruns includes non-running PipelineRuns
5 participants
@divyansh42 @vdemeester @khrm @tekton-robot @waveywaves