-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: label checker action reference #9129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: label checker action reference #9129
Conversation
|
/kind fix |
|
@anithapriyanatarajan: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
862355e to
d63d6c9
Compare
|
/kind misc |
Signed-off-by: Anitha Natarajan <[email protected]>
26617ef to
8a8dfb0
Compare
|
There is a policy issue. The pattern in the policy as per error message is docker://agilepathway/pull-request-label-checker@*, which expects a SHA256 digest to follow. However, the policy also requires that all actions must be pinned to a full-length commit SHA (from the GitHub repository), not a Docker image SHA. So it is failing always. Please allow the policy to use
|
|
/retest |
|
Thanks @anithapriyanatarajan. Since we're now building the container on each run the duration has gone from ~5-10s to >30s which is a shame, but I guess that's the price we have to pay for pinning to known versions (at least for now). Can you add a link to the issue in the PR description please? tektoncd/plumbing#2929 |
Linked the Issue Ref. But if the policy could be adjusted we could revert to Docker format in uses. |
AlanGreene
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
It's running successfully against this PR with the change in place: https://github.com/tektoncd/pipeline/actions/runs/19173646636/job/54812583363?pr=9129
I've also made the same change in tektoncd/dashboard which is working as expected
|
/approve |
waveywaves
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, AlanGreene, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This pull request updates the GitHub Actions workflow configuration for label checking thereby fixes the label checker workflow failures .
This is related to tektoncd/plumbing#2929
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes