Skip to content

Conversation

@anithapriyanatarajan
Copy link
Contributor

@anithapriyanatarajan anithapriyanatarajan commented Nov 7, 2025

Changes

This pull request updates the GitHub Actions workflow configuration for label checking thereby fixes the label checker workflow failures .

This is related to tektoncd/plumbing#2929

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Nov 7, 2025
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2025
@anithapriyanatarajan
Copy link
Contributor Author

/kind fix

@tekton-robot
Copy link
Collaborator

@anithapriyanatarajan: The label(s) kind/fix cannot be applied, because the repository doesn't have them.

In response to this:

/kind fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anithapriyanatarajan anithapriyanatarajan force-pushed the fix-labels-action branch 3 times, most recently from 862355e to d63d6c9 Compare November 7, 2025 14:54
@afrittoli
Copy link
Member

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Nov 7, 2025
Signed-off-by: Anitha Natarajan <[email protected]>
@anithapriyanatarajan
Copy link
Contributor Author

anithapriyanatarajan commented Nov 7, 2025

There is a policy issue. The pattern in the policy as per error message is docker://agilepathway/pull-request-label-checker@*, which expects a SHA256 digest to follow. However, the policy also requires that all actions must be pinned to a full-length commit SHA (from the GitHub repository), not a Docker image SHA. So it is failing always. Please allow the policy to use agilepathway/label-checker@ Ref: https://github.com/agilepathway/label-checker/blob/master/.github/workflows/build_and_push_image.yml#L33 so that this action will work as expected. cc: @vdemeester @AlanGreene

git ls-remote https://github.com/agilepathway/label-checker.git refs/tags/v1.6.65 c3d16ad512e7cea5961df85ff2486bb774caf3c5 refs/tags/v1.6.65

@afrittoli
Copy link
Member

/retest

@afrittoli afrittoli added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/misc Categorizes issue or PR as a miscellaneuous one. labels Nov 7, 2025
@AlanGreene
Copy link
Member

AlanGreene commented Nov 7, 2025

Thanks @anithapriyanatarajan. Since we're now building the container on each run the duration has gone from ~5-10s to >30s which is a shame, but I guess that's the price we have to pay for pinning to known versions (at least for now).

Can you add a link to the issue in the PR description please? tektoncd/plumbing#2929

@anithapriyanatarajan
Copy link
Contributor Author

Thanks @anithapriyanatarajan. Since we're now building the container on each run the duration has gone from ~5-10s to >30s which is a shame, but I guess that's the price we have to pay for pinning to known versions (at least for now).

Can you add a link to the issue in the PR description please? tektoncd/plumbing#2929

Linked the Issue Ref. But if the policy could be adjusted we could revert to Docker format in uses.

Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

It's running successfully against this PR with the change in place: https://github.com/tektoncd/pipeline/actions/runs/19173646636/job/54812583363?pr=9129

I've also made the same change in tektoncd/dashboard which is working as expected

@afrittoli
Copy link
Member

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2025
Copy link
Member

@waveywaves waveywaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, AlanGreene, waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afrittoli,waveywaves]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 55dcf38 into tektoncd:main Nov 11, 2025
42 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants