feat(core): support booting in phar #1672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aazsamir
force-pushed
the
feat/phar-compatible
branch
from
84af6a3 to
b5b14d6
Compare
innocenzi
changed the title
innocenzi
previously requested changes
Nov 3, 2025
Member
innocenzi
left a comment
innocenzi
left a comment
There was a problem hiding this comment.
Can you use the Filesystem\real_path syntax instead?
Also, have you considered more descriptive names? Maybe normalize_path?
Member
|
Awesome. Do you think it would be possible to also PR a test for phars? I've never used them before so I'm not sure about it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to pack my application as a PHAR file. However, using the
realpath()function causes problems because phar files are located in a virtual file system, and tempest does not boot at all.Therefore, I added the
real_path()function, which is safe for phar files, and replaced all calls torealpath()withreal_path().In addition, tempest's internal storage is now configurable, as we cannot create files inside a PHAR file, so we need to specify an external location instead.