-
Couldn't load subscription status.
- Fork 952
Support for DECODE operator #3239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tensorflow/micro Add initial support for DECODE operator. Add reference implementation. Add LUT decompression support. Update op resolvers. Update Makefiles and Bazel BUILD files. Add kernel unit test. bug=fixes tensorflow#3131
…em). Cleanup unit test.
@tensorflow/micro Additional support for DECODE operator. Add Xtensa optimizations for LUT decompression. Move all Xtensa kernel source references to the Xtensa target makefile. bug=fixes tensorflow#3150
@tensorflow/micro Reorganize Xtensa makefiles such that all references to optimized kernel sources are moved to the Xtensa target makefile. Move hifimini kernel sources to the parent directory, and rename them so they do not interfere with the target overlay mechanism of the root makefile. bug=fixes tensorflow#3153
Fix code style errors.
@tensorflow/micro Add reference implementation of pruning to DECODE operator. Makefile and Bazel BUILD file changes. Additional unit tests. bug=fixes tensorflow#3161
Update pruning code with zero-point checks. Add const-tensor checks.
Cleanup tests.
@tensorflow/micro Add comprehensive DECODE unit test for LUT decompression. Update decode_test_helpers.h with additional expected comparison tensor types. Update Makefiles and Bazel build files.
| return i; | ||
| } | ||
| } | ||
| return 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this line reachable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot be reached. Would you prefer /* NOT REACHED */ or MicroPrintf followed by TFLITE_ABORT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer ABORT. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
@tensorflow/micro
Add comprehensive DECODE unit test for LUT decompression.
Update decode_test_helpers.h with additional expected comparison tensor types.
Update Makefiles and Bazel build files.
bug=fixes #3238