fix: Replace hardcoded partition with data resource to support aws-cn and … #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladislav-orlovskiy
changed the title
vladislav-orlovskiy
changed the title
|
@antonbabenko would you mind take a look at this? It's seems small change but it blocks us really bad. |
antonbabenko
approved these changes
Apr 3, 2025
antonbabenko
merged commit f8495d1
into
terraform-aws-modules:master
9 of 15 checks passed
1 task
|
This PR is included in version 4.3.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aws-gov
Description
adding
data "aws_partition" "current" {}and replacing hardcoded:aws:with:${data.aws_partition.current.partition}:Motivation and Context
Currently module outputs incorrect static arn if it runs on China region
#72
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request