-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Updated firewall module with resource prefix naming and added feature #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ravimalvia10
wants to merge
15
commits into
master
Choose a base branch
from
firewall-final-1.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fbd85b7
ci: Updated the ci workflows
ravimalvia10 ed1e6d7
feat: Added for_each condition and primary public ip resource
ravimalvia10 c3812b6
fix: Updated the variables with dynamic type and formatted it based l…
ravimalvia10 6840b5e
feat: added custom name feature
ravimalvia10 3778818
refector: Updated code format
ravimalvia10 46bef36
docs: Updated with resource names and variable names and added branding
ravimalvia10 474adf9
feat: Added resources to show as an example
ravimalvia10 e10b268
chore: removed comments
ravimalvia10 d51f63a
chore: removed unused variables
ravimalvia10 737709b
fix: added destination address argument
ravimalvia10 d912394
chore: updated description of the variables
ravimalvia10 b0d9566
docs: Updated the README.md
ravimalvia10 c8d6dbd
fix: Update main.tf with necesary resource and arguments
ravimalvia10 3bb8e99
fix: Updated the module
ravimalvia10 0092ba2
fix: Updated the code with required changes
ravimalvia10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,3 +44,31 @@ updates: | |
| - "Crew" | ||
| # Allow up to 3 open pull requests for pip dependencies | ||
| open-pull-requests-limit: 3 | ||
|
|
||
| - package-ecosystem: "terraform" # See documentation for possible values | ||
| directory: "/examples/firewall-with-isolated-rules" # Location of package manifests | ||
| schedule: | ||
| interval: "daily" | ||
| # Add assignees | ||
| assignees: | ||
| - "clouddrove-ci" | ||
| # Add reviewer | ||
| reviewers: | ||
| - "approvers" | ||
| - "Crew" | ||
| # Allow up to 3 open pull requests for pip dependencies | ||
| open-pull-requests-limit: 3 | ||
|
|
||
| - package-ecosystem: "terraform" # See documentation for possible values | ||
| directory: "/examples/firewall-with-public-ip-prefix" # Location of package manifests | ||
| schedule: | ||
| interval: "daily" | ||
| # Add assignees | ||
| assignees: | ||
| - "clouddrove-ci" | ||
| # Add reviewer | ||
| reviewers: | ||
| - "approvers" | ||
| - "Crew" | ||
| # Allow up to 3 open pull requests for pip dependencies | ||
| open-pull-requests-limit: 3 | ||
|
Comment on lines
+73
to
+74
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment appears to be a copy-paste from a
pipdependency configuration. It should be updated to be relevant for Terraform dependencies or removed for clarity.