Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions rules/magicmodules/api_definition.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ var APIDefinition = map[string]string{
"google_beyondcorp_app_connection": "beyondcorp.googleapis.com",
"google_beyondcorp_app_connector": "beyondcorp.googleapis.com",
"google_beyondcorp_app_gateway": "beyondcorp.googleapis.com",
"google_beyondcorp_application": "beyondcorp.googleapis.com",
"google_beyondcorp_security_gateway": "beyondcorp.googleapis.com",
"google_beyondcorp_security_gateway_application": "beyondcorp.googleapis.com",
"google_biglake_catalog": "biglake.googleapis.com",
Expand Down Expand Up @@ -288,6 +287,7 @@ var APIDefinition = map[string]string{
"google_developer_connect_git_repository_link": "developerconnect.googleapis.com",
"google_developer_connect_insights_config": "developerconnect.googleapis.com",
"google_dialogflow_agent": "dialogflow.googleapis.com",
"google_dialogflow_conversation_profile": "dialogflow.googleapis.com",
"google_dialogflow_encryption_spec": "dialogflow.googleapis.com",
"google_dialogflow_entity_type": "dialogflow.googleapis.com",
"google_dialogflow_fulfillment": "dialogflow.googleapis.com",
Expand Down Expand Up @@ -491,7 +491,6 @@ var APIDefinition = map[string]string{
"google_network_services_tls_route": "networkservices.googleapis.com",
"google_notebooks_environment": "notebooks.googleapis.com",
"google_notebooks_instance": "notebooks.googleapis.com",
"google_notebooks_location": "notebooks.googleapis.com",
"google_notebooks_runtime": "notebooks.googleapis.com",
"google_oracle_database_autonomous_database": "oracledatabase.googleapis.com",
"google_oracle_database_cloud_exadata_infrastructure": "oracledatabase.googleapis.com",
Expand Down Expand Up @@ -584,7 +583,6 @@ var APIDefinition = map[string]string{
"google_tags_tag_binding": "cloudresourcemanager.googleapis.com",
"google_tags_tag_key": "cloudresourcemanager.googleapis.com",
"google_tags_tag_value": "cloudresourcemanager.googleapis.com",
"google_tpu_node": "tpu.googleapis.com",
"google_transcoder_job": "transcoder.googleapis.com",
"google_transcoder_job_template": "transcoder.googleapis.com",
"google_vmwareengine_cluster": "vmwareengine.googleapis.com",
Expand Down
91 changes: 91 additions & 0 deletions rules/magicmodules/google_netapp_storage_pool_invalid_qos_type.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
// ----------------------------------------------------------------------------
//
// *** AUTO GENERATED CODE *** Type: MMv1 ***
//
// ----------------------------------------------------------------------------
//
// This file is automatically generated by Magic Modules and manual
// changes will be clobbered when the file is regenerated.
//
// Please read more about how to change this file in
// .github/CONTRIBUTING.md.
//
// ----------------------------------------------------------------------------

package magicmodules

import (
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
"github.com/terraform-linters/tflint-plugin-sdk/hclext"
"github.com/terraform-linters/tflint-plugin-sdk/tflint"
)

// GoogleNetappStoragePoolInvalidQosTypeRule checks the pattern is valid
type GoogleNetappStoragePoolInvalidQosTypeRule struct {
tflint.DefaultRule

resourceType string
attributeName string
}

// NewGoogleNetappStoragePoolInvalidQosTypeRule returns new rule with default attributes
func NewGoogleNetappStoragePoolInvalidQosTypeRule() *GoogleNetappStoragePoolInvalidQosTypeRule {
return &GoogleNetappStoragePoolInvalidQosTypeRule{
resourceType: "google_netapp_storage_pool",
attributeName: "qos_type",
}
}

// Name returns the rule name
func (r *GoogleNetappStoragePoolInvalidQosTypeRule) Name() string {
return "google_netapp_storage_pool_invalid_qos_type"
}

// Enabled returns whether the rule is enabled by default
func (r *GoogleNetappStoragePoolInvalidQosTypeRule) Enabled() bool {
return true
}

// Severity returns the rule severity
func (r *GoogleNetappStoragePoolInvalidQosTypeRule) Severity() tflint.Severity {
return tflint.ERROR
}

// Link returns the rule reference link
func (r *GoogleNetappStoragePoolInvalidQosTypeRule) Link() string {
return ""
}

// Check checks the pattern is valid
func (r *GoogleNetappStoragePoolInvalidQosTypeRule) Check(runner tflint.Runner) error {
resources, err := runner.GetResourceContent(r.resourceType, &hclext.BodySchema{
Attributes: []hclext.AttributeSchema{{Name: r.attributeName}},
}, nil)
if err != nil {
return err
}

for _, resource := range resources.Blocks {
attribute, exists := resource.Body.Attributes[r.attributeName]
if !exists {
continue
}

err := runner.EvaluateExpr(attribute.Expr, func(val string) error {
validateFunc := validation.StringInSlice([]string{"QOS_TYPE_UNSPECIFIED", "AUTO", "MANUAL", ""}, false)

_, errors := validateFunc(val, r.attributeName)
for _, err := range errors {
if err := runner.EmitIssue(r, err.Error(), attribute.Expr.Range()); err != nil {
return err
}
}
return nil
}, nil)
if err != nil {
return err
}
}

return nil
}
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func (r *GoogleNetworkServicesGatewayInvalidRoutingModeRule) Check(runner tflint
}

err := runner.EvaluateExpr(attribute.Expr, func(val string) error {
validateFunc := validation.StringInSlice([]string{"NEXT_HOP_ROUTING_MODE", ""}, false)
validateFunc := validation.StringInSlice([]string{"NEXT_HOP_ROUTING_MODE", "EXPLICIT_ROUTING_MODE", ""}, false)

_, errors := validateFunc(val, r.attributeName)
for _, err := range errors {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func (r *GoogleNetworkServicesLbTrafficExtensionInvalidLoadBalancingSchemeRule)
}

err := runner.EvaluateExpr(attribute.Expr, func(val string) error {
validateFunc := validation.StringInSlice([]string{"INTERNAL_MANAGED", "EXTERNAL_MANAGED", ""}, false)
validateFunc := validation.StringInSlice([]string{"INTERNAL_MANAGED", "EXTERNAL_MANAGED"}, false)

_, errors := validateFunc(val, r.attributeName)
for _, err := range errors {
Expand Down
1 change: 1 addition & 0 deletions rules/magicmodules/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ var Rules = []tflint.Rule{
NewGoogleMonitoringSloInvalidSloIdRule(),
NewGoogleMonitoringUptimeCheckConfigInvalidCheckerTypeRule(),
NewGoogleNetappBackupVaultInvalidBackupVaultTypeRule(),
NewGoogleNetappStoragePoolInvalidQosTypeRule(),
NewGoogleNetappStoragePoolInvalidServiceLevelRule(),
NewGoogleNetappVolumeInvalidSecurityStyleRule(),
NewGoogleNetappVolumeQuotaRuleInvalidTypeRule(),
Expand Down
2 changes: 1 addition & 1 deletion rules/magicmodules/verify/validation.go
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ func ValidateBase64String(i interface{}, val string) ([]string, []error) {
}

func ValidateBase64URLString(i interface{}, val string) ([]string, []error) {
_, err := base64.URLEncoding.DecodeString(i.(string))
_, err := base64.RawURLEncoding.DecodeString(i.(string))
if err != nil {
return nil, []error{fmt.Errorf("could not decode %q as a valid base64URL value.", val)}
}
Expand Down
2 changes: 1 addition & 1 deletion tools/magic-modules
Submodule magic-modules updated 489 files