acceptance tests only run if lint passes #424
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the v6 acceptance test workflow to only run when the lint workflow passes successfully, implementing a dependency chain between workflows. The change ensures code quality validation before running expensive acceptance tests.
- Replaces direct push trigger with workflow_run trigger that depends on lint workflow completion
- Adds conditional logic to key jobs to check lint workflow success status
- Maintains manual and pull request trigger capabilities
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| test-setup: | ||
| runs-on: ubuntu-latest | ||
| # Only run if lint workflow succeeded or if triggered manually/scheduled | ||
| if: ${{ github.event.workflow_run.conclusion == 'success' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' || github.event_name == 'pull_request' }} |
There was a problem hiding this comment.
The conditional logic is duplicated between jobs. Consider extracting this to a reusable workflow condition or defining it once at the workflow level to improve maintainability.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
copliot how to do that
|
@ericclemmons when u have a moment, have a look at this. I also see this 
|
No description provided.