Make sure the default document is the correct instance #1295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
commented
Aug 8, 2025
| */ | ||
| const defaultOptionsDirect: Required<Options> = { | ||
| const getDefaultOptionsDirect = (): Required<Options> => ({ |
There was a problem hiding this comment.
Could also do:
Suggested change
| const getDefaultOptionsDirect = (): Required<Options> => ({ | |
| const getDefaultOptions = (overrides: Options): Required<Options> => ({ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I noticed this in a setup where a jsdom instance was recreated for each test and globals were reassigned,
userEventused an outdated version of the globaldocument.Why
It's fixable by calling
userEvent.setup({ document })every time, but this PR makes that unnecessary.How
Use a function to obtain default values, this makes it capture
globalThis.documentat the timeuserEvent.setup()is called.Checklist