CSS2Properties styleIndex was shared across all instances #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
being hit by the same issue, any plan to merge this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing a problem that when a node was created and then was set to hidden by jQuery, any node I created after that point would also be hidden.
I looked into the code and CSS2Properties' styleIndex was getting set to supportedStyles. Any modifications to styleIndex would also update supportedStyles, so further instances of CSS2Properties will also get those changes.
I've updated it to instead make a clone using extend and also added a test for the issue.
Thanks for the extremely useful project!