Basic Windows support using Rhino engine #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull request thatcher#23, 031b304/b645a70 from moschel. Added Windows batch files to run envjs using either Rhino or the Rhino debugger. Fixed an issue in xhr.js Envjs.localXHR when running under Rhino, url parameter was tested for pattern match to determine Content-Type, but fails under Rhino since the url parameter passed is a Java object, not a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to get the current envjs to function from the command-line using the included Rhino platform. Three basic changes:
Basic envjs example (for example a simple test.html file, window.location="test.html"; in test.js, then "bin\envjs test.js") works on Windows after these three changes.