Skip to content

Bugfix/remove unimplemented objc methods #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix/remove unimplemented objc methods #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
[Release Notes](https://docs.usercentrics.com/cmp_in_app_sdk/latest/about/history/)

### 2.18.5 - January 14, 2025

## iOS Bug Fixes

* Remove the following Objc methods that are missing JS backing: `showCMP`, `getUSPData`, `getTCFString`


### 2.18.4 - January 07, 2025

## Android Bug Fixes
Expand Down
10 changes: 0 additions & 10 deletions ios/RNUsercentricsModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@
@interface RCT_EXTERN_MODULE(RNUsercentricsModule, NSObject)
RCT_EXTERN_METHOD(configure:(NSDictionary *)dict)

RCT_EXTERN_METHOD(showCMP:(NSDictionary *)dict
resolve:(RCTPromiseResolveBlock)resolve
reject:(RCTPromiseRejectBlock)reject)

RCT_EXTERN_METHOD(showFirstLayer:(NSDictionary *)dict
resolve:(RCTPromiseResolveBlock)resolve
reject:(RCTPromiseRejectBlock)reject)
Expand All @@ -29,9 +25,6 @@ @interface RCT_EXTERN_MODULE(RNUsercentricsModule, NSObject)
RCT_EXTERN_METHOD(isReady:(RCTPromiseResolveBlock)resolve
reject:(RCTPromiseRejectBlock)reject)

RCT_EXTERN_METHOD(getTCFString:(RCTPromiseResolveBlock)resolve
reject:(RCTPromiseRejectBlock)reject)

RCT_EXTERN_METHOD(getControllerId:(RCTPromiseResolveBlock)resolve
reject:(RCTPromiseRejectBlock)reject)

Expand All @@ -47,9 +40,6 @@ @interface RCT_EXTERN_MODULE(RNUsercentricsModule, NSObject)
RCT_EXTERN_METHOD(getUserSessionData:(RCTPromiseResolveBlock)resolve
reject:(RCTPromiseRejectBlock)reject)

RCT_EXTERN_METHOD(getUSPData:(RCTPromiseResolveBlock)resolve
reject:(RCTPromiseRejectBlock)reject)

RCT_EXTERN_METHOD(getTCFData:(RCTPromiseResolveBlock)resolve
reject:(RCTPromiseRejectBlock)reject)

Expand Down
2 changes: 0 additions & 2 deletions src/__tests__/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,13 @@ jest.mock("react-native", () => {
RN.NativeModules.RNUsercentricsModule = {
configure: jest.fn(),
isReady: jest.fn(),
showCMP: jest.fn(),
showFirstLayer: jest.fn(),
restoreUserSession: jest.fn(),
getControllerId: jest.fn(),
getABTestingVariant: jest.fn(),
getConsents: jest.fn(),
getCMPData: jest.fn(),
getUserSessionData: jest.fn(),
getUSPData: jest.fn(),
getTCFData: jest.fn(),
getAdditionalConsentModeData: jest.fn(),
changeLanguage: jest.fn(),
Expand Down