Skip to content

API feature: return existing link with error on creation #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

API feature: return existing link with error on creation #912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6db7e47
simplest way to get link with existing customurl
mxsbc May 19, 2025
1e17280
Merge pull request #1 from mxsbc/get-link-by-url
mxsbc May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/handlers/helpers.handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function error(error, req, res, _next) {
}


return res.status(statusCode).json({ error: message });
return res.status(statusCode).json({ error: message, data: error.data });
};


Expand Down Expand Up @@ -140,4 +140,4 @@ module.exports = {
parseQuery,
rateLimit,
verify,
}
}
4 changes: 2 additions & 2 deletions server/handlers/links.handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ async function create(req, res) {
if (tasks[1]) {
const error = "Custom URL is already in use.";
res.locals.errors = { customurl: error };
throw new CustomError(error);
throw new CustomError(error, 409, utils.sanitize.link(tasks[1]));
}

// Create new link
Expand Down Expand Up @@ -659,4 +659,4 @@ module.exports = {
redirect,
redirectProtected,
redirectCustomDomainHomepage,
}
}