-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Rename mesasge.hbs to message.hbs #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
suryatanjung
wants to merge
14
commits into
thedevs-network:main
Choose a base branch
from
suryatanjung:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Filename Typo
Fixed method name typo
- sort by created_at or visit_count - defaults to created_at desc - uses ORDER BY in sql - falls back to id desc if invalid field - minor comment typo 'adddress' to 'addres'
- pass to query.link.get() calls - send to handlebars template - keeps sort state on htmx requests - few minor comment typo
- hidden inputs store sort state - onclick calls sortBy() function - added sort indicator spans
- hidden inputs store sort state - onclick calls sortBy() function - added sort indicator spans - matches user panel
sortBy() handles column clicks and toggles asc/desc updateSortIndicators() shows arrows (↑↓) initializeSortIndicators() runs on page load and htmx updates resets pagination when sorting changes
sortable columns get pointer cursor and hover effect sort arrows styled with margin and color fixed justify-content on .views, .users-links-count, .domains-links-count headers data cells stay right-aligned
- sort by created_at or links_count - defaults to created_at desc - ORDER BY with join count - fallback to id desc
- sort by created_at or links_count - defaults to created_at desc - ORDER BY with join count - fallback to id desc - minor comment typo 'adddress' to 'address'
- pass to query.user.getAdmin() - send to handlebars template - keeps sort state on htmx requests
- pass to query.domain.getAdmin() - send to handlebars template - keeps sort state on htmx requests - add missing semicolon
- hidden inputs store sort state - onclick calls sortBy() function - added sort indicator spans
- hidden inputs store sort state - onclick calls sortBy() function - added sort indicator spans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed filename typo and method name typo