-
Notifications
You must be signed in to change notification settings - Fork 104
Create an overview of the installation procedure #4120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Create an overview of the installation procedure #4120
Conversation
The PR preview for 0d4d1ae is available at theforeman-foreman-documentation-preview-pr-4120.surge.sh The following output files are affected by this PR: |
Working on fixing the build issues. Not ready for review yet. |
8fb89ed
to
c05e6d7
Compare
c05e6d7
to
6783e24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Akshay! This works better than a list with links.
.Planning | ||
Make sure that your infrastructure meets the prerequisites for installation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discrete headings (like .Planning
) will eventually be reported as issues by asciidoctor-dita-vale so it would be good not to add new ones. Thinking about how to make this section flow naturally, one option might be this:
.Planning | |
Make sure that your infrastructure meets the prerequisites for installation: | |
During planning, you will make sure that your infrastructure meets the prerequisites for installation. | |
This includes the following actions: |
This is just a quick suggestion, feel free to tweak it :) The changes I'm making are:
- Replacing discrete heading with a descriptive "During planning, (...)". This adds more words but avoids the need for the discrete heading.
This includes the following actions:
helps prevent potential future situations when a new "action" might be added to planning but noone updates this list. (I'm not sure about the word "action" to be honest.)
What do you think? If this sounds good, can you look into updating the other discrete headings in a similar way? Whatever wording you choose, they should all be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, I believe that this would be a valid use case for a definition list:
.Planning | |
Make sure that your infrastructure meets the prerequisites for installation: | |
Planning:: | |
Make sure that your infrastructure meets the prerequisites for installation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went with Lena's suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with the current wording. Overview sections like this are difficult to maintain in the long term and if we really are adding one like this, the wording should be as future-proof as possible and should not duplicate a table of contents.
In my suggestions, I was thinking about what an overview section could look like so that it provides additional value over a table of contents and indicates that the list of actions in the overview is really just an overview rather than a complete list. In its current form, the PR has been steered back to duplicating a table of contents and introducing a maintenance burden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize. That's a valid concern.
Speaking in more general terms, this request came from Red Hat's downstream. In upstream, I've been mostly hearing about concerns that the installation guide is very long, which doesn't work well for upstream users. Therefore, I'm wondering: Should we only include the new overview for Satellite to address the downstream need, while excluding it from upstream to better accommodate the upstream users' needs? |
IMO there's value in this overview, so I am OK with adding it for all flavours. |
Adding a module for installation overview with high level steps and links to each step. JIRA: https://issues.redhat.com/browse/SAT-30834
6783e24
to
0d4d1ae
Compare
ifndef::foreman-deb[] | ||
* Install {EL} 9 on a newly deployed system. | ||
endif::[] | ||
ifdef::foreman-deb[] | ||
* Install Debian 12 or Ubuntu 22.04 on a newly deployed system. | ||
endif::[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still sounds strange to me because "install" and "deploy" could be considered (partial) synonyms. (Or at least software installation is part of deployment, the way I see it.)
What about something like this?
ifndef::foreman-deb[] | |
* Install {EL} 9 on a newly deployed system. | |
endif::[] | |
ifdef::foreman-deb[] | |
* Install Debian 12 or Ubuntu 22.04 on a newly deployed system. | |
endif::[] | |
ifndef::foreman-deb[] | |
* Ensure a fresh installation of {EL} 9 on your server. | |
endif::[] | |
ifdef::foreman-deb[] | |
* Ensure a fresh installation of Debian 12 or Ubuntu 22.04 on your server. | |
endif::[] |
Feel free to get a second opinion. I'm not sure how to say this either :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternative:
ifndef::foreman-deb[] | |
* Install {EL} 9 on a newly deployed system. | |
endif::[] | |
ifdef::foreman-deb[] | |
* Install Debian 12 or Ubuntu 22.04 on a newly deployed system. | |
endif::[] | |
ifndef::foreman-deb[] | |
* Deploy a server with a fresh {EL} 9 installation. | |
endif::[] | |
ifdef::foreman-deb[] | |
* Deploy a server with a fresh Debian 12 or Ubuntu 22.04 installation. | |
endif::[] |
Or even:
ifndef::foreman-deb[] | |
* Install {EL} 9 on a newly deployed system. | |
endif::[] | |
ifdef::foreman-deb[] | |
* Install Debian 12 or Ubuntu 22.04 on a newly deployed system. | |
endif::[] | |
ifndef::foreman-deb[] | |
* Deploy a server with fresh {EL} 9. | |
endif::[] | |
ifdef::foreman-deb[] | |
* Deploy a server with fresh Debian 12 or Ubuntu 22.04. | |
endif::[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see installing as a part of a deployment. For example, a deployment may also include creating the server (like a VM) with the right size. You then install the software on that server.
Feedback we are getting from users indicates that guides are long and hard to navigate. From how this PR has been developing, I'm not convinced that adding a new overview at the beginning will help solve either of these issues: the guide will get even longer, it will duplicate the table of contents and is also likely to get outdated over time. Similarly, I'm not convinced that a section like this would improve navigation, which is the point of the original request, per "First-time customers sometimes lose their way during the installation process." mentioned in the Jira ticket. For example, if the overview mentions action items in imperative voice ("ensure this" and "configure this"), there is a risk users might start immediately thinking about how to make these actions happen -- but that's not what we want in an overview; that should come later in the procedures. Compare that with the Upgrade path overview section in the Upgrading guide, which tends to avoid describing action items and instead provides a high-level overview to prepare users for what awaits them. If there really is a need for an overview in the installation guide, I believe we should find a way to make it much shorter and also be clear about the fact that it's just an overview and not a complete list of actions. Alternatively, we could also focus on improving navigation through improving the table of contents. However, that's probably what we would only do for the future guide based on the new installer rather than the existing guide based on the new installer. |
Adding a module for installation overview with high level steps and links to each step.
JIRA: https://issues.redhat.com/browse/SAT-30834
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into:
Review checklists
Tech review (performed by an Engineer who did not author the PR; can be skipped if tech review is unnecessary):
Style review (by a Technical Writer who did not author the PR):